-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add customer satisfactory (CSAT) card #4899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
compulim
wants to merge
34
commits into
main
Choose a base branch
from
feat-csat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,455
−455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
reviewed
Oct 16, 2023
tdurnford
reviewed
Oct 16, 2023
tdurnford
reviewed
Oct 16, 2023
packages/component/src/types/external/OrgSchema/PropertyValueSpecification.ts
Show resolved
Hide resolved
tdurnford
reviewed
Oct 16, 2023
tdurnford
reviewed
Oct 16, 2023
tdurnford
reviewed
Oct 16, 2023
tdurnford
reviewed
Oct 16, 2023
tdurnford
reviewed
Oct 16, 2023
packages/component/src/providers/RovingTabIndex/RovingTabIndexComposer.tsx
Outdated
Show resolved
Hide resolved
tdurnford
reviewed
Oct 16, 2023
packages/component/src/Styles/StyleSet/CustomerSatisfactoryAttachment.ts
Outdated
Show resolved
Hide resolved
tdurnford
reviewed
Oct 16, 2023
packages/component/src/Attachment/CustomerSatisfactory/private/useStrings.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
Customer Satisfactory Card (CSAT card)
Description
Power Virtual Agents and many customers implemented customer satisfactory (CSAT) cards using Adaptive Cards. However, as Adaptive Cards is designed for general purpose. Thus, the accessibility experience is not great for CSAT cards.
We are adding new attachment renderer for CSAT cards by leveraging https://schema.org/ReviewAction.
Design
We are using https://schema.org/ReviewAction for the representation of the CSAT card. The following is excerpt of the activity containing the CSAT card.
Explanation of fields
content['@context']
"https://schema.org"
.content['@type']
"ReviewAction"
.content.actionStatus
"CompletedActionStatus"
, the card is submitted. Otherwise, the card is ready to submit.content.description
content.resultReview['@type']
"Review"
.content.resultReview.reviewRating['@type']
"Rating"
.content.resultReview.reviewRating.ratingValue
1
to5
orundefined
, default toundefined
.content.resultReview.reviewRating['ratingValue-input']
ratingValue
should be used as "input" parameters (a.k.a. request body). See https://schema.org/docs/actions.html for details.content.resultReview.reviewRating['ratingValue-input']['@type']
"PropertyValueSpecification"
.content.resultReview.reviewRating['ratingValue-input'].valueName
content.target
"EntryPoint"
.content.target['@type']
"EntryPoint"
.content.target.actionPlatform
"https://directline.botframework.com"
.content.target.urlTemplate
contentType
"application/ld+json"
.Current designs and limitations:
resultReview
must be thing of"Review"
."UserReview"
and other subclass of"Review"
is not supportedresultReview.reviewRating.bestRating
andresultReview.reviewRating.worstRating
are ignoredactionStatus
isCompletedActionStatus
, it indicates the review is submitted, thus,target
is optional. Otherwise, review should be submittable andtarget
must be specifiedtarget
could be a non-templated URL, it is highly recommendedtarget
is a thing ofEntryPoint
Target URL
When the user change the rating, it will change the
resultReview.reviewRating.ratingValue
. In Schema.org actions, theratingValue-input
will be used to describe how theratingValue
is used in the request body of the action.In the example payload,
ratingValue-input.valueName
israte
. When filling thetarget.urlTemplate
, it will replace the variablerate
with the user rating.If the user rated 4, the URL template will be expanded as by replacing variable
rate
with4
:Thus, the postback activity payload will become:
Followings are supported protocol and their query parameters:
ms-directline-postback:
value
valuetype
isapplication/json
, will send as JSON viaactivity.value
, otherwise, will send as string viaactivity.text
.ms-directline-postback:
valuetype
value
is a complex object, specify "application/json". This is not recommended because non-compliance with Direct Line protocol.ms-directline-imback:
title
activity.text
.ms-directline-imback:
value
title
parameter is not specified, will send this value asactivity.text
.ms-directline-messageback:
value
activity.value
.ms-directline-messageback:
text
activity.text
.ms-directline-messageback:
displaytext
Specific Changes
useOpenURL
for internal use onms-directline-*:
protocolRovingTabIndexProvider
OrgSchemaThing
should not typed outtype
:type
is strictly forentities
onlydocs/CUSTOMER_SATISFACTORY_CARD.md
CHANGELOG.md
Review Checklist
Browser and platform compatibilities reviewedz-index
)Documents reviewed (docs, samples, live demo)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)